sync: update CI config files #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
web3-bot/sync
branch
from
2880e49
to
29d70c6
Compare
Unfortunately, this test relies heavily on timing.
Stebalien
force-pushed
the
web3-bot/sync
branch
2 times, most recently
from
eaf2871
to
cfdf87e
Compare
Stebalien
force-pushed
the
web3-bot/sync
branch
from
cfdf87e
to
1460c01
Compare
If we don't pause for some time, the scheduler can get stuck in a busy loop.
|
Hm. So... that's one problem with the auto-merge. |
@Stebalien We could change the auto-merge logic such that it only triggers if all commits in a PR have |
|
Yeah, that would be really nice. Commit author probably makes sense, rebase should be fine. NOTE: I'm slightly concerned about it allowing contributors to bypass merge policies. I'm wondering if we should protect the web3-bot branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing to commit protocol/.github@137ffc6.