QUIC/WebTransport Transport sometimes uses the wrong socket to dial out. #2913
Comments
2color
changed the title
This was referenced Aug 13, 2024
2color
added a commit
that referenced
this issue
Aug 21, 2024
|
Do you know why your public ip doesn't show up as an observed address? Why don't other peers see this address, even if they can't dial you back? |
I don't know. I can debug more to check this. |
Update & InsightsI've been debugging this and have some useful insights:
LogsNote that I incrementally added some logs as I was going through this. The latest attempt was using the following branch Successful attempt to hole punchPeer A: Peer B (Kubo behind NAT): Unsuccessful attempt to hole punchPeer A Peer B (Kubo behind NAT): Unsuccessful attempt 2Peer A: Peer B (Kubo behind NAT): Unsuccessful attemp 3Peer A: Peer B (Kubo behind NAT) Successful attempt with different libp2p configIn this version, I changed the libp2p host config from: h, err := libp2p.New(libp2p.DefaultMuxers, libp2p.Muxer("/mplex/6.7.0", mplex.DefaultTransport), libp2p.EnableHolePunching())`to: ip4ListenAddr, _ := multiaddr.NewMultiaddr("/ip4/0.0.0.0/udp/0/quic-v1")
h, err := libp2p.New(libp2p.DefaultMuxers, libp2p.Muxer("/mplex/6.7.0", mplex.DefaultTransport), libp2p.EnableHolePunching(), libp2p.ListenAddrs(ip4ListenAddr))Essentially only listening with QUIC on the ip4 interface. Peer A: |
|
Ah, I think I know the issue here. I'll work on the fix now. |
MarcoPolo
changed the title
|
The issue here is that the QUIC/WebTransport Transport don't have any logic to prefer their own socket when dialing out. So what happens is:
The holepunching failure is a downstream failure from this. |
|
@2color if you get a chance, could you verify the linked PR does indeed fix your issue? |
|
@MarcoPolo I tested #2936 and it was able to discover its own observed address consistently and reliably. I also added a bit of logging and confirmed that it was reusing the socket and port corresponding to the transport. |
MarcoPolo
pushed a commit
that referenced
this issue
Aug 28, 2024
MarcoPolo
pushed a commit
that referenced
this issue
Aug 28, 2024
* fix: allow punching undialable host public ip fixes #2913 * chore: use interface listen addrs to enable dctur * fix: filter public addresses * chore: remove unused function * chore: formatting --------- Co-authored-by: Daniel N <[email protected]>
sukunrt
pushed a commit
that referenced
this issue
Aug 30, 2024
* fix: allow punching undialable host public ip fixes #2913 * chore: use interface listen addrs to enable dctur * fix: filter public addresses * chore: remove unused function * chore: formatting --------- Co-authored-by: Daniel N <[email protected]>
MarcoPolo
pushed a commit
that referenced
this issue
Sep 4, 2024
* fix: allow punching undialable host public ip fixes #2913 * chore: use interface listen addrs to enable dctur * fix: filter public addresses * chore: remove unused function * chore: formatting --------- Co-authored-by: Daniel N <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
Given the following scenario:
h, err := libp2p.New(libp2p.DefaultMuxers, libp2p.EnableHolePunching())h.Addrs()contains public IPs:Problem
/libp2p/dcutrprotocol enabled."error": "failed to open hole-punching stream: failed to negotiate protocol: protocols not supported: [/libp2p/dcutr]"}error (logged by Peer B).Source of the problem
Based on debugging with @sukunrt, it appears to be related to the following lines:
go-libp2p/p2p/protocol/holepunch/svc.go
Line 109 in 16a27ff
go-libp2p/p2p/protocol/holepunch/svc.go
Line 174 in 16a27ff
We were able to work around this problem and successfully hole punch by replacing
s.ids.OwnObservedAddrs()withs.host.Addrs()). This was a temporary measure, as we may just want to add the listen addrs to the observed addrs.Related issue
The text was updated successfully, but these errors were encountered: