This repository has been archived by the owner on May 26, 2022. It is now read-only.
Add context option to disable dialing when opening a new stream #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
previously requested changes
Apr 10, 2019
swarm.go
Outdated
| var ErrNoConn = errors.New("no usable connection to peer") | ||
|
|
||
| // ContextOption is the type of context options understood by the swarm | ||
| type ContextOption string |
There was a problem hiding this comment.
Nit: This should probably be a newtype of struct{}.
Also, we should probably put this in go-libp2p-net. Now that we're using go modules, this should be easy (:tada:)
There was a problem hiding this comment.
They need to be comparable, whatever that implies. Also the example in godoc uses a string alias type, so I went with it.
There was a problem hiding this comment.
I'll update go-libp2p-net to provide the option.
There was a problem hiding this comment.
Moved to go-libp2p-net in libp2p/go-libp2p-net#42
There was a problem hiding this comment.
Updated to use the nodial option in go-libp2p-net.
vyzo
dismissed
Stebalien’s stale review
stebalien approced on slack while on mobile.
|
@Stebalien LGTM'ed on mobile; merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essential for (non active) relays who under no circumstances want to initiate a dial to a peer.
It was necessitated by the discovery of a large number of goroutines doing recursive dialing in a relay.