Use validator in SearchValue #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
4 tasks
Stebalien
requested changes
Sep 25, 2018
parallel.go
Outdated
|
|
||
| for v := range resCh { | ||
| if best == nil { | ||
| if r.Validator.Validate(key, v) != nil { |
There was a problem hiding this comment.
Technically, we should be able to rely on the underlying router. Given that we don't validate anywhere else, I'm thinking we should drop this (for consistency). Thoughts?
magik6k
force-pushed
the
fix/search-validate
branch
from
8de03dc
to
2b26552
Compare
Stebalien
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually a small patch, bulk of the changes is caused by changing the
ParallelandTieredtypes.Only real changes are in
parallel.go:searchSearchValue