Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

chore: update deps #239

Merged
merged 1 commit into from
Nov 14, 2021
Merged

chore: update deps #239

merged 1 commit into from
Nov 14, 2021

Conversation

aschmahmann
Copy link

@marten-seemann I bumped a bunch of the dependencies here. Most of these are dependencies that are already present in places like go-libp2p, but there's not necessarily a pressing need for them.

Figured this might be an illustrative way of looking at our dependency graph and how it falls behind.

github.com/lucas-clemente/quic-go v0.24.0
github.com/minio/sha256-simd v0.1.1
github.com/multiformats/go-multiaddr v0.3.1
github.com/minio/sha256-simd v1.0.0
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Present in go-libp2p master via github.com/multiformats/[email protected]

github.com/minio/sha256-simd v0.1.1
github.com/multiformats/go-multiaddr v0.3.1
github.com/minio/sha256-simd v1.0.0
github.com/multiformats/go-multiaddr v0.4.0
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

present in go-libp2p master

github.com/multiformats/go-multiaddr-fmt v0.1.0
github.com/onsi/ginkgo v1.16.4
github.com/onsi/gomega v1.13.0
github.com/prometheus/client_golang v1.9.0
github.com/prometheus/client_golang v1.11.0
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

present in go-libp2p master via github.com/prometheus/[email protected]

github.com/libp2p/go-libp2p-core v0.10.0
github.com/libp2p/go-libp2p-tls v0.3.0
github.com/libp2p/go-netroute v0.1.3
github.com/libp2p/go-netroute v0.1.6
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

present in go-libp2p master

@@ -5,18 +5,17 @@ go 1.16
require (
github.com/golang/mock v1.6.0
github.com/ipfs/go-log v1.0.4
github.com/klauspost/compress v1.11.7
github.com/klauspost/compress v1.13.6
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing that go me looking at this repo for bumping dependencies.

This repo has a dependency on https://github.com/cespare/xxhash/ (via vendoring) which has an issue with Go 1.17 that's been fixed cespare/xxhash#54.

Copy link
Collaborator

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-266 LOC in go.sum? That's amazing, looks like one of the dependencies cleaned up its dependency tree.

@marten-seemann marten-seemann merged commit 3db1b6f into master Nov 14, 2021
@marten-seemann
Copy link
Collaborator

Reverting, since it broke the build on master.

@marten-seemann
Copy link
Collaborator

Weird, trying to recreate this PR leads to massively inflating go.sum and go.mod.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants