Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make IPv6 subnet colocation optional as a peer score parameter #387

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vyzo
Copy link
Collaborator

@vyzo vyzo commented Sep 12, 2020

No description provided.

@vyzo vyzo changed the title make IPv6 subnet colocation optional, default to false make IPv6 subnet colocation optional as a peer score parameter Sep 12, 2020
@daviddias
Copy link
Member

What's the rationale? was this being abused?

@vyzo
Copy link
Collaborator Author

vyzo commented Sep 14, 2020

no, but it can create problems with providers like textile.

@vyzo
Copy link
Collaborator Author

vyzo commented Sep 14, 2020

basically I want to make it an option, it's something we discussed with the eth2 folks as well.

Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind editing the PR body and explaining the observations from Eth2 and Filecoin that justify making this change? The patch is easy to understand, but the desired impact isn't, and that makes it obscure for the community to follow the direction. Thanks!

@ribasushi
Copy link

cc @jleni this might be of interest too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants