This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
Let ID implement encoding.Binary[Un]Marshaler and encoding.Text[Un]Marshaler #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vyzo
approved these changes
Feb 25, 2019
|
Thank you @vyzo |
|
@vyzo always front-running me 😛 |
|
@raulk should I have waited? I think in IPFS-land merging after approval is ok but I'm not sure if libp2p is stricter here. |
|
@hsanjuan No, it’s fine 👍 Unless it’s something more controversial that requires more buy-in from the team; this wasn’t the case. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encoding a
map[peer.ID]somethingto JSON it cannot be parsed back becauseIDdoesn't implementTextMarshaler.While the
BinaryMarshaleris not strictly necessary, it is a safeguard in case at some point an ID is no longer an alias for a string.