This repository has been archived by the owner on May 26, 2022. It is now read-only.
update go-libp2p-core, remove integration test #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add the transports test (go-libp2p-testing) in a submodule? This significantly reduces coverage. But yeah, this change looks reasonable. |
Stebalien
approved these changes
Jul 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this might make people unhappy, but we have to remove the integration test here, otherwise we'll end up in an import cycle, since go-libp2p uses Noise as a default security (related: #101).
Alternatively, we could make this repo a multi-module repo, with an
integrationmodule that imports both go-libp2p and go-libp2p-noise. I'm not sure if that's an elegant solution though. Arguably, such an integration test belongs into go-libp2p, not into go-libp2p-noise.