add ctx canceled err check #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guillaumemichel Thanks for your reply. I've tested the new commit code locally without any issues. The previous code will cause memory leaks, please refer to the issue for details: #958 If this code can be merged, can a minor version be released? Otherwise, my program's memory will keep growing. Thank you very much! |
guillaumemichel
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
The tests are now passing, thanks @godeamon ! I will create the new release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE: #958
There is no need to re-establish the connection for context canceled error, otherwise a lot of memory will be generated when calling GetValue in large numbers.
Looking forward to someone reviewing the code.