integrate some basic opentelemetry tracing #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Jul 29, 2021
| ) | ||
|
|
||
| var Tracer = otel.Tracer("") |
There was a problem hiding this comment.
empty string uses the default tracer instance, which is fine because this isnt a top level application.
| @@ -390,6 +395,9 @@ func workers(numWorkers int, fn func(interface{}), inputs <-chan interface{}) { | |||
| } | |||
|
|
|||
| func (dht *FullRT) GetClosestPeers(ctx context.Context, key string) ([]peer.ID, error) { | |||
| ctx, span := Tracer.Start(ctx, "GetClosestPeers") | |||
There was a problem hiding this comment.
Tell the error to go deal with itself?
Stebalien
approved these changes
Jul 30, 2021
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on getting better insight to why things are randomly slow. Having this sort of insight will help a lot.
Please recommend other things that are worth tracing, or other attributes i should add to the existing spans.