various staticcheck fixes #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
commented
Apr 1, 2021
| @@ -197,6 +197,7 @@ func isEUI(ip net.IP) bool { | |||
| } | |||
|
|
|||
| func sameV6Net(a, b net.IP) bool { | |||
| //lint:ignore SA1021 We're comparing only parts of the IP address here. | |||
There was a problem hiding this comment.
This is annoying, especially since we need both comments here (this new one for staticcheck, the //nolint for gopls (?)).
Furthermore, I think this is a false positive anyway: dominikh/go-tools#957.
Stebalien
approved these changes
Apr 1, 2021
routing.go
Outdated
| }) | ||
| return nil, err | ||
| default: | ||
| if err != nil && err != internal.ErrInvalidRecord { |
There was a problem hiding this comment.
Hm. I liked this way of doing thing. Which tool has a problem with it?
There was a problem hiding this comment.
staticcheck didn't like that default wasn't the first or the last. I can restore it to a switch if you prefer.
There was a problem hiding this comment.
Eh, up to you. Merge when ready.
There was a problem hiding this comment.
Switched it back to a switch.
marten-seemann
force-pushed
the
fix-staticcheck
branch
from
e4d1dbb
to
5d95bf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.