This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Consolidate abstractions and core types into go-libp2p-core #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned raulk
Apr 16, 2019
ghost
added
the
in progress
label
Apr 16, 2019
vyzo
reviewed
Apr 16, 2019
deprecated.go
Outdated
) | ||
|
||
// Deprecated: use github.com/libp2p/go-libp2p-core/host.Host instead. | ||
type Host = moved.Host |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have more types that need to be aliased -- all the interfaces I would say.
7 tasks
raulk
force-pushed
the
consolidate-skeleton
branch
from
April 17, 2019 16:31
632b122
to
3dbb8ff
Compare
raulk
force-pushed
the
consolidate-skeleton
branch
from
May 24, 2019 18:29
b5ba371
to
ca694e2
Compare
FYI, this seems to break builds when using
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a batch across go-libp2p repos to consolidate abstractions, interfaces and core types into libp2p/go-libp2p-core. See branch
consolidate-skeleton
there.Work is being performed in the
consolidate-skeleton
branch across repos.In this PR, we:
Merge strategy: squash and rebase.