v0.7.0 breaks backward compatibility for multiple packages

[lthibault]

Hello,

I've just upgraded to github.com/libp2p/[email protected], which removes helpers.FullClose. As of this upgrade, the following packages are broken:

• github.com/libp2p/[email protected]
• github.com/libp2p/[email protected]
• github.com/libp2p/[email protected]

Here's the error message that appears:

# github.com/libp2p/go-libp2p/p2p/protocol/identify
../../../../pkg/mod/github.com/libp2p/[email protected]/p2p/protocol/identify/id.go:380:3: undefined: helpers.FullClose
../../../../pkg/mod/github.com/libp2p/[email protected]/p2p/protocol/identify/id.go:424:20: undefined: helpers.FullClose
../../../../pkg/mod/github.com/libp2p/[email protected]/p2p/protocol/identify/id_delta.go:29:8: undefined: helpers.FullClose
../../../../pkg/mod/github.com/libp2p/[email protected]/p2p/protocol/identify/peer_loop.go:132:8: undefined: helpers.FullClose
../../../../pkg/mod/github.com/libp2p/[email protected]/p2p/protocol/identify/peer_loop.go:153:8: undefined: helpers.FullClose
# github.com/libp2p/go-libp2p-pubsub
../../../../pkg/mod/github.com/libp2p/[email protected]/comm.go:128:8: undefined: helpers.FullClose
../../../../pkg/mod/github.com/libp2p/[email protected]/tracer.go:263:5: undefined: helpers.FullClose
# github.com/libp2p/go-libp2p-kad-dht
../../../../pkg/mod/github.com/libp2p/[email protected]/dht_net.go:396:7: undefined: helpers.FullClose
../../../../pkg/mod/github.com/libp2p/[email protected]/dht_net.go:446:7: undefined: helpers.FullClose

[aschmahmann]

@lthibault I recommend taking a look at the release notes https://github.com/libp2p/go-libp2p-core/releases/tag/v0.7.0. This release contains breaking changes which means that dependencies will have to get updated (e.g. libp2p/go-libp2p#1001).

If you're interested in why this change was made take a look at the corresponding PR (#166)

[lthibault]

@aschmahmann Thanks for the quick reply!

If I understand correctly, the solution here is to wait for these packages to be updated? (Totally fine. Just asking 🙂)

[Stebalien]

Yes.