This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
use buffer pool in newDelimitedReader #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of allocating the buffer flat
ghost
assigned 
|
Actually there is no useful place to put the buffer back in the pool. |
|
I added a |
Stebalien
approved these changes
Apr 11, 2019
|
The global pool probably works just as well for this, and they can be reused by the hop stream buffers. |
|
Oh you mean a pool for the actual readers. Yeah, maybe so. |
|
Yep. |
|
I will merge as is, as using a pool for the delimitedReaders themselves adds quite a bit of ugly complexity (we need to track the buffers in two steps). |
|
Well, we could just leave the buffers inside the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of allocating the buffer flat, given how short-lived it is.