This repository has been archived by the owner on May 26, 2022. It is now read-only.
Blank host should support signed records #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't we need to emit events, update this record when the addresses change, etc? |
|
@Stebalien We emit addr changes events when we want to in the Identify tests for now. I'm okay with making that change here too. |
Stebalien
approved these changes
May 5, 2020
|
This is strictly speaking better. My point was that, to be a completely correct host implementation, we'd need to emit all the right events. But I'm fine filing an issue and fixing it later. |
|
@Stebalien Issue: #43 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already do this in the
Hostnow. So, we should also do it here for tests.