-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dcutr #279
feat: dcutr #279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this page would be better as a much higher level overview of dcutr and nat holepunching. It can even be shorter. And simply link to the spec to have it explain the technical details.
content/concepts/nat/dcutr.md
Outdated
they can continue using the relay connection. Once the two nodes have synchronized, they can simultaneously | ||
open a connection to each other's addresses, allowing for successful hole punching. | ||
|
||
The DCUtR protocol supports TCP and QUIC connections with slightly different procedures. For TCP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is also somewhat technical, and I feel like would be better to just link to the spec directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is important to have but simplified it even more. We also link to the spec at the bottom.
Maybe we want to link: https://tailscale.com/blog/how-nat-traversal-works/ |
Let's do that! At some point, I'd like to have our own post about NAT traversal that uses pretty diagrams, but for now, the Tailscale blog post is a good reference. |
Co-authored-by: Prithvi Shahi <[email protected]>
@MarcoPolo Can you take a look at this PR, it looks good to merge from my end |
@MarcoPolo or @mxinden need a review from either of you |
This is ready, will merge when ci/builds finish |
Context
Latest preview
Please view the latest Fleek preview here.