Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dcutr #279

Merged
merged 9 commits into from
Feb 25, 2023
Merged

feat: dcutr #279

merged 9 commits into from
Feb 25, 2023

Conversation

salmad3
Copy link
Member

@salmad3 salmad3 commented Jan 3, 2023

Context

  • Adds content for dcutr.
  • Part of overall content additions for the NAT section.

Latest preview

Please view the latest Fleek preview here.

@salmad3 salmad3 marked this pull request as draft January 3, 2023 08:08
@salmad3 salmad3 added the ready for review PR is ready for review label Jan 6, 2023
@salmad3 salmad3 requested review from raulk and mxinden January 6, 2023 11:16
@salmad3 salmad3 marked this pull request as ready for review January 6, 2023 11:16
Copy link
Contributor

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this page would be better as a much higher level overview of dcutr and nat holepunching. It can even be shorter. And simply link to the spec to have it explain the technical details.

content/concepts/nat/dcutr.md Outdated Show resolved Hide resolved
content/concepts/nat/dcutr.md Outdated Show resolved Hide resolved
they can continue using the relay connection. Once the two nodes have synchronized, they can simultaneously
open a connection to each other's addresses, allowing for successful hole punching.

The DCUtR protocol supports TCP and QUIC connections with slightly different procedures. For TCP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is also somewhat technical, and I feel like would be better to just link to the spec directly.

Copy link
Member Author

@salmad3 salmad3 Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is important to have but simplified it even more. We also link to the spec at the bottom.

@MarcoPolo
Copy link
Contributor

Maybe we want to link: https://tailscale.com/blog/how-nat-traversal-works/

@marten-seemann
Copy link
Contributor

Maybe we want to link: https://tailscale.com/blog/how-nat-traversal-works/

Let's do that! At some point, I'd like to have our own post about NAT traversal that uses pretty diagrams, but for now, the Tailscale blog post is a good reference.

@salmad3 salmad3 removed the request for review from raulk January 26, 2023 01:01
@salmad3 salmad3 added the P1 High label Jan 26, 2023
content/concepts/nat/dcutr.md Outdated Show resolved Hide resolved
content/concepts/nat/dcutr.md Outdated Show resolved Hide resolved
content/concepts/nat/dcutr.md Outdated Show resolved Hide resolved
content/concepts/nat/dcutr.md Show resolved Hide resolved
@p-shahi
Copy link
Member

p-shahi commented Feb 7, 2023

@MarcoPolo Can you take a look at this PR, it looks good to merge from my end

@p-shahi
Copy link
Member

p-shahi commented Feb 13, 2023

@MarcoPolo or @mxinden need a review from either of you

@p-shahi p-shahi removed P1 High ready for review PR is ready for review labels Feb 23, 2023
@MarcoPolo
Copy link
Contributor

This is ready, will merge when ci/builds finish

@p-shahi p-shahi merged commit cbfaa8f into master Feb 25, 2023
@p-shahi p-shahi deleted the nat/dcutr branch February 25, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants