Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post: rust-libp2p webrtc in the browser #117

Merged
merged 16 commits into from
Mar 15, 2024

Conversation

DougAnderson444
Copy link
Contributor

Draft pull request for the blog post referenced in #113

@DougAnderson444 DougAnderson444 changed the title init commit for rust-libp2p webrtc in the browser blog post: rust-libp2p webrtc in the browser Nov 1, 2023
@DougAnderson444
Copy link
Contributor Author

Feedback /additions / suggestions are welcome. As I am writing this, I'm realizing that the real news here is that rust-libp2p is running in the browser over WebRTC, so I'm making the distinction between server vs browser a lot.

The repo has an example, so I'm torn whether to include any code examples there or just point people to the repo / docs. I'm leaning towards pointing, as rust docs are kept up to date through doctest so it'll always be more up to date whereas a blog entry will eventually fall out of date.

So keeping more towards a news announcement?

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes me excited about the use-cases this enables.

Thank you for the work and sorry for the late review.

I think this still needs a couple of iterations. Here are some suggestions.

src/_blog/rust-libp2p-browser-to-server.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-browser-to-server.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-browser-to-server.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-browser-to-server.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-browser-to-server.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-browser-to-server.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-browser-to-server.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-browser-to-server.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-browser-to-server.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-browser-to-server.md Outdated Show resolved Hide resolved
@thomaseizinger
Copy link
Contributor

The repo has an example, so I'm torn whether to include any code examples there or just point people to the repo / docs. I'm leaning towards pointing, as rust docs are kept up to date through doctest so it'll always be more up to date whereas a blog entry will eventually fall out of date.

So keeping more towards a news announcement?

Sounds good to me!

I'll hold off on a more detailed review for now to reduce the churn :)
Let me know if you want another pair of eyes.

@DougAnderson444
Copy link
Contributor Author

Thanks for touching base gentlemen! Yes it's a really rough draft right now but wanted to get a feel for your thoughts on the content.

I'll have another look after libp2p day at Lab Week

@DougAnderson444
Copy link
Contributor Author

Had another look at this today and made some changes. It is looking good and I think the right emphasis is starting to emerge.

@DougAnderson444 DougAnderson444 marked this pull request as ready for review December 5, 2023 19:12
@mxinden
Copy link
Member

mxinden commented Dec 6, 2023

@DougAnderson444 ping us once you would like another review. Thank you for your work!

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @DougAnderson444 ! I've left a few comments but overall looks good to me :)

src/_blog/rust-libp2p-browser-to-server.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-browser-to-server.md Outdated Show resolved Hide resolved
Copy link

@retrohacker retrohacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really excited to see progress on #4389, connectivity between two browser tabs in libp2p-rust would be 🔥

src/_blog/rust-libp2p-browser-to-server.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-browser-to-server.md Outdated Show resolved Hide resolved
src/_blog/rust-libp2p-browser-to-server.md Outdated Show resolved Hide resolved
It might be more beneficial to release this post than to keep editing it for perfection... if the reviewer likes the post, I recommend posting it. DA.
@retrohacker
Copy link

:shipit: ?

@dhuseby dhuseby merged commit 57662c2 into libp2p:main Mar 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants