PB-4578: Fix RT CR status with duplicate resources and RT controller with duplicate effort. #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgajawada-px
requested review from
lalat-das,
diptiranjanpx,
prashanthpx,
siva-portworx,
px-kesavan and
pallav-px
|
Can one of the admins verify this patch? |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1529 +/- ##
==========================================
+ Coverage 65.93% 65.99% +0.05%
==========================================
Files 43 43
Lines 5349 5349
==========================================
+ Hits 3527 3530 +3
+ Misses 1490 1488 -2
+ Partials 332 331 -1 ☔ View full report in Codecov by Sentry. |
Rohit-PX
reviewed
Oct 12, 2023
| path.Operation == stork_api.ModifyResourcePathValue) { | ||
| return fmt.Errorf("unsupported operation type for given path : %s", path.Operation) | ||
| for _, object := range objects.Items { | ||
| logrus.Debugf("Objects Item %v", object) |
Rohit-PX
reviewed
Oct 12, 2023
| dynamicClient := localInterface.Resource( | ||
| object.GetObjectKind().GroupVersionKind().GroupVersion().WithResource(resource.Name)).Namespace(getTransformNamespace(transform.Namespace)) | ||
| if err := resourcecollector.TransformResources(object, []stork_api.TransformResourceInfo{*resInfo}, metadata.GetName(), metadata.GetNamespace()); err != nil { | ||
| log.TransformLog(transform).Errorf("Unable to transform resource: %s/%s having gvk:%v with error: %v", resInfo.Namespace, resInfo.Name, resInfo.GroupVersionKind, err) |
There was a problem hiding this comment.
instead of gvk say group version kind.
|
Please add integration test to stork. |
|
As discussed with anjan currently we can rely on unit tests |
sgajawada-px
changed the title
sgajawada-px
force-pushed
the
PB-4578
branch
2 times, most recently
from
aa1056c
to
3dfa5b4
Compare
- Remove loop on the paths in the validateTransformResource as this is already been doing in the resourcecollector.TransformResources - Because of this redandent computation issue is solved and RT CR status will not be overloded with duplicate resource information. - Remove path.Operation validation in validateTransformResource as this is already completed with the RT CR is in Initial Stage using the ResourceTransformationController.validateSpecPath method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
To fix the performance while transforming resources in rt controller by removing the redundant computations which are even occupying the RT CR status
Does this PR change a user-facing CRD or CLI?:
no
Is a release note needed?:
no
Does this change need to be cherry-picked to a release branch?:
Yes because it is a bug in the latest release stork release.
JIRA BUG: https://portworx.atlassian.net/browse/PB-4578
Unit Test Result