Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise flags #162

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

paulfertser
Copy link
Contributor

I assume many libopencm3 users are taking rules.mk from these examples.

BTW, is there any reason to not enable LTO by default for libopencm3 itself? An LTO-enabled library can be used for both LTO ond non-LTO builds equally well, it just takes up a bit more space on host computer storage.

@paulfertser
Copy link
Contributor Author

I have backported these changes from my current job project, haven't really tested examples themselves.

@karlp
Copy link
Member

karlp commented Dec 18, 2017

IIRC; At the time, LTO enabled didn't work for LTO and non-lto builds, if it can be turned on now safely for all (using "fat" lto obs I presume?) I'm all for it.

@karlp
Copy link
Member

karlp commented Dec 18, 2017

gdb3 change looks good, no reason not to do that. I've just kinda been ignoring the examples repo, have been hoping to almost wholesale replace it, but that's reaching for too much maybe

@karlp
Copy link
Member

karlp commented Dec 18, 2017

I've pulled the gdb3 and cross ref in. For LTO, I'd like to see something done in conjunction with the lib itself, not just something hidden behind a make variable here.

rtti/exceptions are interesting enough, but without a way to turn them on, we're making the rules out to ban portions of c++ without a way back. I think that should get looked at separately from just "optimize flags"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants