Eliminate no.tbl #1196
Merged
Eliminate no.tbl #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertfrees
added
the
cleanup
What problem is this PR solving? What bug are you referring to? |
egli
approved these changes
Mar 29, 2022
|
|
Oh, I get it. Reducing the includes avoids this bug. OK, workaround is fine with me |
bertfrees
force-pushed
the
eliminate-no.tbl
branch
from
99d6672 to
3c66333
Compare
The metadata is moved to no-no-g3.ctb. see #1196
bertfrees
force-pushed
the
eliminate-no.tbl
branch
from
3c66333 to
ddc6187
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata is moved to no-no-g3.ctb.
I have already applied this patch in release 3.21.0-p1 of liblouis-nar. It was done as a work around for liblouis/liblouis-java#10.
You might argue that this is not so great because it masks a bug that we should try to fix instead. But we've already spend a lot of time trying to fix that bug. And this is a good change anyway because the *.tbl tables were always meant to be temporary.