We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In some situations, the config parsing code will fail on boolean values that use integers (0 or 1).
Add to .gitconfig:
.gitconfig
[core] logAllRefUpdates = 1
Then, perform some operation in a bare repo (such as adding a new commit). It will fail with failed to map '1'.
failed to map '1'
All boolean config values should support integers.
Some boolean config values fail to parse.
86b8549
macOS
The issue is that some functions (like git_config_lookup_map_value) call the low-level git__parse_bool which does not support integers. I think, instead, they should be using git_config_parse_bool which handles integers.
git_config_lookup_map_value
git__parse_bool
git_config_parse_bool
The text was updated successfully, but these errors were encountered:
Fix parsing boolean config values when using git_config_get_mapped an…
a4b8600
…d git_config_lookup_map_value (fixes issue libgit2#5555) Signed-off-by: Sven Strickroth <[email protected]>
Fixed via #5626 - thanks @csware!
Sorry, something went wrong.
No branches or pull requests
In some situations, the config parsing code will fail on boolean values that use integers (0 or 1).
Reproduction steps
Add to
.gitconfig
:Then, perform some operation in a bare repo (such as adding a new commit). It will fail with
failed to map '1'
.Expected behavior
All boolean config values should support integers.
Actual behavior
Some boolean config values fail to parse.
Version of libgit2 (release number or SHA1)
86b8549
Operating system(s) tested
macOS
Notes
The issue is that some functions (like
git_config_lookup_map_value
) call the low-levelgit__parse_bool
which does not support integers. I think, instead, they should be usinggit_config_parse_bool
which handles integers.The text was updated successfully, but these errors were encountered: