evdns: recreate ns socket after ENOTCONN #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there is no other change except |
yes, you can safely ignore them |
azat
reviewed
Jun 1, 2020
azat
reviewed
Jun 1, 2020
azat
changed the title
I'm sorry, I can't reproduce the error in my device. |
azat
reviewed
Jun 8, 2020
Ok, this doesn't look hurmful, so this can be merged |
azat
reviewed
Jun 8, 2020
azat
reviewed
Jun 8, 2020
azat
reviewed
Jun 8, 2020
7 tasks
github-merge-queue bot
pushed a commit
to n0-computer/iroh
that referenced
this pull request
Nov 26, 2024
## Description In order to handle supsension and exits on mobile. we need to rebind our UDP sockets when they break. This PR adds the ability to rebind the socket on errors, and does so automatically on known suspension errors for iOS. When reviewing this, please specifically look at the duration of lock holding, as this is the most sensitive part in this code. Some references for these errors - libevent/libevent#1031 - #2939 ### TODOs - [x] code cleanup - [x] testing on actual ios apps, to see if this actually fixes the issues - [ ] potentially handle port still being in use? this needs some more thoughts Closes #2939 ## Breaking Changes The overall API for `netmon::UdpSocket` has changed entirely, everything else is the same. ## Notes & open questions - I have tried putting this logic higher in the stack, but unfortunately that did not work out. - We might not want to infinitely rebind a socket if the same error happens over and over again, unclear how to handle this. ## Change checklist - [ ] Self-review. - [ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [ ] Tests if relevant. - [ ] All breaking changes documented. --------- Co-authored-by: Philipp Krüger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with ghazel's patch.
Closes: #265