Improve GedcomParser registration and add GedcomImporter command #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-ai[bot]](https://avatars.githubusercontent.com/in/307814?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request improves the registration of the
GedcomParserin the service provider and adds a newGedcomImportercommand.Description
The changes in this pull request include:
Improving the registration of the
GedcomParserin the service provider. Previously, theGedcomParserwas registered using an anonymous function, which could lead to issues with dependency injection. The new implementation uses the$appparameter to ensure proper dependency injection.Adding a new
GedcomImportercommand to the package. This command can be used to import GEDCOM files into the application.Summary
GedcomParserregistration inServiceProvider.phpGedcomImportercommandSuggested changes from Sweep Chat by @curtisdelicata. Continue chatting at https://sweep-chat-demo.vercel.app/c/30ea4e77-b06b-488a-94c7-b6c59d883a94.