Skip to content

Commit

Permalink
Add error display
Browse files Browse the repository at this point in the history
  • Loading branch information
@libertyernie
libertyernie committed May 22, 2024
1 parent c926a69 commit baf6573
Show file tree
Hide file tree
Showing 6 changed files with 241 additions and 4 deletions.
2 changes: 1 addition & 1 deletion LoopingAudioConverter.Conversion/Converter.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public static class Converter {
public static async Task ConvertFilesAsync(IConverterEnvironment env, IConverterOptions o, IReadOnlyList<string> inputFiles, IProgress<double> progress = null) {
FFmpegEngine effectEngine = File.Exists(env.FFmpegPath)
? new FFmpegEngine(env.FFmpegPath)
: throw new Exception("Could not find ffmpeg - please specify ffmpeg_path in .config file");
: throw new Exception("Either the file LoopingAudioConverter.config does not contain ffmpeg_path, or ffmpeg.exe could not be found at that path.");

IAudioExporter getExporter() {
switch (o.ExporterType) {
Expand Down
87 changes: 87 additions & 0 deletions LoopingAudioConverter/ErrorForm.Designer.cs
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 18 additions & 0 deletions LoopingAudioConverter/ErrorForm.cs
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
using System.Windows.Forms;

namespace LoopingAudioConverter {
public partial class ErrorForm : Form {
public string Message {
get {
return textBox1.Text;
}
set {
textBox1.Text = value;
}
}

public ErrorForm() {
InitializeComponent();
}
}
}
120 changes: 120 additions & 0 deletions LoopingAudioConverter/ErrorForm.resx
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,120 @@
<?xml version="1.0" encoding="utf-8"?>
<root>
<!--
Microsoft ResX Schema
Version 2.0
The primary goals of this format is to allow a simple XML format
that is mostly human readable. The generation and parsing of the
various data types are done through the TypeConverter classes
associated with the data types.
Example:
... ado.net/XML headers & schema ...
<resheader name="resmimetype">text/microsoft-resx</resheader>
<resheader name="version">2.0</resheader>
<resheader name="reader">System.Resources.ResXResourceReader, System.Windows.Forms, ...</resheader>
<resheader name="writer">System.Resources.ResXResourceWriter, System.Windows.Forms, ...</resheader>
<data name="Name1"><value>this is my long string</value><comment>this is a comment</comment></data>
<data name="Color1" type="System.Drawing.Color, System.Drawing">Blue</data>
<data name="Bitmap1" mimetype="application/x-microsoft.net.object.binary.base64">
<value>[base64 mime encoded serialized .NET Framework object]</value>
</data>
<data name="Icon1" type="System.Drawing.Icon, System.Drawing" mimetype="application/x-microsoft.net.object.bytearray.base64">
<value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
<comment>This is a comment</comment>
</data>
There are any number of "resheader" rows that contain simple
name/value pairs.
Each data row contains a name, and value. The row also contains a
type or mimetype. Type corresponds to a .NET class that support
text/value conversion through the TypeConverter architecture.
Classes that don't support this are serialized and stored with the
mimetype set.
The mimetype is used for serialized objects, and tells the
ResXResourceReader how to depersist the object. This is currently not
extensible. For a given mimetype the value must be set accordingly:
Note - application/x-microsoft.net.object.binary.base64 is the format
that the ResXResourceWriter will generate, however the reader can
read any of the formats listed below.
mimetype: application/x-microsoft.net.object.binary.base64
value : The object must be serialized with
: System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
: and then encoded with base64 encoding.
mimetype: application/x-microsoft.net.object.soap.base64
value : The object must be serialized with
: System.Runtime.Serialization.Formatters.Soap.SoapFormatter
: and then encoded with base64 encoding.
mimetype: application/x-microsoft.net.object.bytearray.base64
value : The object must be serialized into a byte array
: using a System.ComponentModel.TypeConverter
: and then encoded with base64 encoding.
-->
<xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
<xsd:import namespace="http://www.w3.org/XML/1998/namespace" />
<xsd:element name="root" msdata:IsDataSet="true">
<xsd:complexType>
<xsd:choice maxOccurs="unbounded">
<xsd:element name="metadata">
<xsd:complexType>
<xsd:sequence>
<xsd:element name="value" type="xsd:string" minOccurs="0" />
</xsd:sequence>
<xsd:attribute name="name" use="required" type="xsd:string" />
<xsd:attribute name="type" type="xsd:string" />
<xsd:attribute name="mimetype" type="xsd:string" />
<xsd:attribute ref="xml:space" />
</xsd:complexType>
</xsd:element>
<xsd:element name="assembly">
<xsd:complexType>
<xsd:attribute name="alias" type="xsd:string" />
<xsd:attribute name="name" type="xsd:string" />
</xsd:complexType>
</xsd:element>
<xsd:element name="data">
<xsd:complexType>
<xsd:sequence>
<xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
<xsd:element name="comment" type="xsd:string" minOccurs="0" msdata:Ordinal="2" />
</xsd:sequence>
<xsd:attribute name="name" type="xsd:string" use="required" msdata:Ordinal="1" />
<xsd:attribute name="type" type="xsd:string" msdata:Ordinal="3" />
<xsd:attribute name="mimetype" type="xsd:string" msdata:Ordinal="4" />
<xsd:attribute ref="xml:space" />
</xsd:complexType>
</xsd:element>
<xsd:element name="resheader">
<xsd:complexType>
<xsd:sequence>
<xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
</xsd:sequence>
<xsd:attribute name="name" type="xsd:string" use="required" />
</xsd:complexType>
</xsd:element>
</xsd:choice>
</xsd:complexType>
</xsd:element>
</xsd:schema>
<resheader name="resmimetype">
<value>text/microsoft-resx</value>
</resheader>
<resheader name="version">
<value>2.0</value>
</resheader>
<resheader name="reader">
<value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<resheader name="writer">
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
</root>
9 changes: 9 additions & 0 deletions LoopingAudioConverter/LoopingAudioConverter.csproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@
</Reference>
</ItemGroup>
<ItemGroup>
<Compile Include="ErrorForm.cs">
<SubType>Form</SubType>
</Compile>
<Compile Include="ErrorForm.Designer.cs">
<DependentUpon>ErrorForm.cs</DependentUpon>
</Compile>
<Compile Include="VGAudioOptions\BxstmOptions.cs" />
<Compile Include="VGAudioOptions\VGAudioOptionsBase.cs" />
<Compile Include="VGAudioOptions\HcaOptions.cs" />
Expand Down Expand Up @@ -113,6 +119,9 @@
<EmbeddedResource Include="AACQualityForm.resx">
<DependentUpon>AACQualityForm.cs</DependentUpon>
</EmbeddedResource>
<EmbeddedResource Include="ErrorForm.resx">
<DependentUpon>ErrorForm.cs</DependentUpon>
</EmbeddedResource>
<EmbeddedResource Include="VGAudioOptions\VGAudioOptionsForm.resx">
<DependentUpon>VGAudioOptionsForm.cs</DependentUpon>
</EmbeddedResource>
Expand Down
9 changes: 6 additions & 3 deletions LoopingAudioConverter/OptionsForm.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,10 @@ public OptionsForm() {
}) {
string v = ConfigurationManager.AppSettings[str];
if (v == null) {
MessageBox.Show(this, $"The .config file setting {str} could not be found.", Text, MessageBoxButtons.OK, MessageBoxIcon.Warning);
MessageBox.Show(this, $"The file LoopingAudioConverter.config does not have a setting {str}.", Text, MessageBoxButtons.OK, MessageBoxIcon.Warning);
}
if (!File.Exists(v)) {
MessageBox.Show(this, $"The file {v} could not be found.", Text, MessageBoxButtons.OK, MessageBoxIcon.Warning);
MessageBox.Show(this, $"The file LoopingAudioConverter.config has a {str} of {v}, but the file at that path is missing.", Text, MessageBoxButtons.OK, MessageBoxIcon.Warning);
}
}
};
Expand Down Expand Up @@ -444,7 +444,10 @@ private async void btnOkay_Click(object sender, EventArgs e) {
await t;
} catch (Exception ex) {
Console.Error.WriteLine(ex);
MessageBox.Show(this, "An error occurred.\r\nFor more details, run from cmd.exe and write a log file:\r\n\r\nLoopingAudioConverter.exe 2> log.txt", ex.GetType().Name, MessageBoxButtons.OK, MessageBoxIcon.Error);
using (var form = new ErrorForm()) {
form.Message = ex.ToString();
form.ShowDialog(this);
}
}
runningTasks.Remove(t);
UpdateTitle();
Expand Down

0 comments on commit baf6573

Please sign in to comment.