This repository has been archived by the owner on Apr 27, 2023. It is now read-only.
remove ci-semver job #1348
Merged
remove ci-semver job #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merging after discussion in standup. Will revisit question after rollout. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently semver of the components lags waaaay behind master.
We've had to change the nginx config for master and since this is share with semver it breaks the pipeline.
I we want to use semver we can retag the components and then revert this PR. Currently my feeling is that we don't need semver as our components are not reused by others and the branch-hash-date tags work just fine.
If we don't end up using semver I'd make another PR to tidy up the makefile, dockerfile etc. I've got a reminder in #1268