-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement rate limiting #699
Conversation
3e6621a
to
c41d80c
Compare
I've created an issue about moving stuff upstream into Pando: AspenWeb/pando.py#581. |
@Changaco: I am currently reviewing this PR. Are you able to access Gratipay's HackerOne inbox? |
@EdOverflow No. I remember proposing to help with Gratipay's HackerOne a while back, but I wasn't given access. |
If there is no concrete feedback I'm going to merge this soon. |
c41d80c
to
ac075c1
Compare
Rebased on master. Will merge once Travis is green. |
This is now deployed. |
This branch implements half of #658 and half of #61, closes #478, and also closes #495.
The proposed rate limits are:
The hardest part for the account creation rate limits was actually determining the IP address of the request in a reliable way. I ended up implementing the logic in the python app (could be moved upstream to Pando).
Ping @EdOverflow since this is about protecting Liberapay from DoS attacks (and other people from email spam).
Remaining TODO: