Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds initial support for 358K (treating as non-formaldehyde) #8

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

dotvezz
Copy link
Member

@dotvezz dotvezz commented Apr 11, 2023

No description provided.

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6e49741) 99.06% compared to head (380d359) 99.06%.

❗ Current head 380d359 differs from pull request most recent head ffeef3a. Consider uploading reports for the commit ffeef3a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files          21       21           
  Lines         963      964    +1     
=======================================
+ Hits          954      955    +1     
  Misses          9        9           
Impacted Files Coverage Δ
libdyson/__init__.py 100.00% <100.00%> (ø)
libdyson/const.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dotvezz dotvezz merged commit 41e9078 into libdyson-wg:main Apr 11, 2023
@@ -10,6 +10,7 @@
DEVICE_TYPE_PURE_COOL_FORMALDEHYDE = "438E"
DEVICE_TYPE_PURE_COOL_DESK = "520"
DEVICE_TYPE_PURE_HUMIDIFY_COOL = "358"
DEVICE_TYPE_PURIFIER_HUMIDIFY_COOL = "358"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be "358K"?

@dotvezz
Copy link
Member Author

dotvezz commented Apr 11, 2023

@kddude yes, yes it should. I'll get a fix in tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants