Check for blank LocalCredentials instead of None during sign in #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotvezz
approved these changes
Jan 10, 2024
|
That test failure is because of an outdated codecov config. I'll update and rerun later. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 22 22
Lines 1025 1025
=======================================
Hits 1016 1016
Misses 9 9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't get the auto-setup to work with my "MyDyson" account in either Home Assistant or with the local tool. Upon looking at the trace locally I found this line and figured I'd try changing it from
is Nonetonotin case the API changed (I have 2 Lightcycles) - as soon as I did it worked fine.