Proper fan mode handling (Dyson Poor Cool Link) #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
working on libdyson-wg/ha-dyson#70
I don't know how to test these changes, but I think they should work.
I added a
preset_mode
variable toDysonDevice
class, but probably it should only be in theDyson Cool Link
class.I also don"t know, why the
is_on
method checksif fan_mode in ["AUTO","FAN"]
and doesn't usefan_mode != "OFF"
.