Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper fan mode handling (Dyson Poor Cool Link) #18

Merged
merged 4 commits into from
Apr 1, 2024

Conversation

Silther
Copy link
Contributor

@Silther Silther commented Nov 8, 2023

working on libdyson-wg/ha-dyson#70

I don't know how to test these changes, but I think they should work.
I added a preset_mode variable to DysonDevice class, but probably it should only be in the Dyson Cool Link class.
I also don"t know, why the is_on method checks if fan_mode in ["AUTO","FAN"] and doesn't use fan_mode != "OFF".

@Silther
Copy link
Contributor Author

Silther commented Nov 9, 2023

@dotvezz this should be ready for review

@Silther
Copy link
Contributor Author

Silther commented Jan 10, 2024

@dotvezz what do you think?

@dotvezz
Copy link
Member

dotvezz commented Jan 10, 2024

@Silther hey, I owe you big apologies for the delay on this! Will take a good look and test ASAP.

@Silther
Copy link
Contributor Author

Silther commented Jan 10, 2024

No worries, I just wasn't sure if I did something wrong

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e8b946) 99.12% compared to head (9f8a2da) 99.12%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files          22       22           
  Lines        1025     1033    +8     
=======================================
+ Hits         1016     1024    +8     
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dotvezz dotvezz merged commit 7b7a8dd into libdyson-wg:main Apr 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants