Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the hchr field for Formaldehyde values #15

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

dotvezz
Copy link
Member

@dotvezz dotvezz commented Jul 6, 2023

Reference discussion link: libdyson-wg/ha-dyson#4

The hcho field in MQTT is of an unknown unit/scale and has no known conversion factor to a known unit. However, it was recently discovered that hchr (referred to as "High Res Formaldehyde" in the android app) has a clean conversion factor of n/1000 to mg/m^3.

Reference discussion link: libdyson-wg/ha-dyson#4

The `hcho` field in MQTT is of an unknown unit/scale and has no known
conversion factor to a known unit. However, it was recently discovered
that `hchr` (referred to as "High Res Formaldehyde" in the android app)
has a clean conversion factor of n/1000 to mg/m^3.
@dotvezz dotvezz force-pushed the task/change-formaldehyde-field branch from 7344136 to 5a6c3e1 Compare July 6, 2023 03:59
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4229ce3) 99.06% compared to head (5a6c3e1) 99.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files          21       21           
  Lines         963      963           
=======================================
  Hits          954      954           
  Misses          9        9           
Impacted Files Coverage Δ
libdyson/cloud/account.py 100.00% <100.00%> (ø)
libdyson/dyson_device.py 97.17% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dotvezz dotvezz merged commit b7ab8b6 into libdyson-wg:main Jul 6, 2023
@dotvezz dotvezz deleted the task/change-formaldehyde-field branch July 6, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant