trying a more direct refactor strategy

libdyson/dyson_device.py

@@ -17,7 +17,7 @@
     DysonConnectionRefused,
     DysonConnectTimeout,
     DysonInvalidCredential,
-    DysonNotConnected,
+    DysonNotConnected, DysonNoEnvironmentalData,
 )
 from .utils import mqtt_time
 
@@ -198,24 +198,6 @@ def __init__(self, serial: str, credential: str, device_type: str):
         self._environmental_data = {}
         self._environmental_data_available = threading.Event()
 
-    def interview(self) -> None:
-        if not self._status_data_available.is_set():
-            self.request_environmental_data()
-            self._environmental_data_available.wait(timeout=TIMEOUT)
-
-        def get_test(self):
-            """ For testing since I don't have formaldehyde devices """
-            return 1
-        setattr(DysonFanDevice, "test", get_test)
-
-        _LOGGER.warning("checking for hcho")
-        if "hcho" in self._environmental_data:
-            _LOGGER.warning("Found hcho")
-            def get_formaldehyde(self):
-                """Return formaldehyde reading."""
-                return int(self._get_environmental_field_value("hcho"))
-            setattr(DysonFanDevice, "formaldehyde", property(get_formaldehyde))
-
     @property
     def device_type(self) -> str:
         """Device type."""
@@ -239,6 +221,14 @@ def speed(self) -> Optional[int]:
             return None
         return int(speed)
 
+    def wait_for_environmental_data(self):
+        if not self._status_data_available.is_set():
+            self.request_current_status()
+            self._environmental_data_available.wait(timeout=TIMEOUT)
+
+        if not self._environmental_data_available.is_set():
+            raise DysonNoEnvironmentalData
+
     @property
     @abstractmethod
     def is_on(self) -> bool:
@@ -274,6 +264,15 @@ def warning_code(self) -> str:
         """Return warning code."""
         return self._get_field_value(self._status, "wacd")
 
+    @property
+    def formaldehyde(self) -> Optional[int]:
+        """Return formaldehyde reading."""
+        val = self._get_environmental_field_value("hcho")
+        if val is None:
+            return None
+
+        return int(val)
+
     @property
     def humidity(self) -> int:
         """Return humidity in percentage."""
@@ -296,16 +295,21 @@ def sleep_timer(self) -> int:
 
     @staticmethod
     def _get_field_value(state: Dict[str, Any], field: str):
-        return state[field][1] if isinstance(state[field], list) else state[field]
+        try:
+            return  state[field][1] if isinstance(state[field], list) else state[field]
+        except:
+            return None
 
-    def _get_environmental_field_value(self, field, divisor=1):
+    def _get_environmental_field_value(self, field, divisor=1) -> Optional[int | float]:
         value = self._get_field_value(self._environmental_data, field)
         if value == "OFF":
             return ENVIRONMENTAL_OFF
         if value == "INIT":
             return ENVIRONMENTAL_INIT
         if value == "FAIL":
             return ENVIRONMENTAL_FAIL
+        if value == "NONE" or value is None:
+            return None
         if divisor == 1:
             return int(value)
         return float(value) / divisor

libdyson/exceptions.py

@@ -55,3 +55,7 @@ class DysonConnectionRefused(DysonException):
 
 class DysonFailedToParseWifiInfo(DysonException):
     """Represents failed to parse WiFi information."""
+
+
+class DysonNoEnvironmentalData(DysonException):
+    """Represents mqtt not connected."""

setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = libdyson-neon
-version = 0.10.2
+version = 0.11.0
 author = The libdyson Working Group
 author_email = [email protected]
 license = MIT License