Add Normal Mode #71
Merged
Add Normal Mode #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it make sense to change the |
|
I know I said I'd try to keep discussion on the other thread, but I saw this and had to reply directly:
Congrats on your first PR! I hope it won't be your last, feel free to stick around! |
|
Testing your work combined with my PR, confirmed this works for me! Thanks for your contribution. If you don't have any questions or issues with my PR, feel free to merge it into your fork. Once that's done, we'll be able to merge your fork into the main repo. Sorry for the complex process there 😅. Let me know if you have any questions! |
Cleaning unneeded libdyson changes
|
I have merged your PR. |
dotvezz
approved these changes
Sep 28, 2023
|
As a humble user... Thank you! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing #70.
I must say, I have never done a PR before and haven't much coding experience (yet).
I just want to know if what I started with makes any sense at all and if I am on the right track