New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use record id & lookup queries to more reliably update #3

Merged

Niallfitzy1 merged 1 commit into main from lean-on-record-ids

Sep 6, 2023

Collaborator

Niallfitzy1 commented Sep 5, 2023

Expands on learnings from #2 to try again to fix #1

Uses the Record.ID to update DNS records when present
When not present queries for the matching record & updates by id as long as one match is found
If no match is found we create the record
Similar logic is used to delete records
Hydrates the Created record ids as they are missing from the Porkbun response
Fully re-writes the tests to be more readable & explict


          chore: rely on record id & lookup queries when missing to more reliab…

5a0cc67

…ly update existing records

Niallfitzy1 merged commit c5d0f88 into main

Niallfitzy1 deleted the lean-on-record-ids branch

September 6, 2023 19:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet