cpr::Session Is Now Unmovable/Copyable
#999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will be keep open for the next week or so, to ensure there are no other important arguments against this approach. |
COM8
force-pushed
the
fix/disable_session_move
branch
from
fa9d8d4
to
2b56200
Compare
Why? cpr::Session is a complex object and while moving one has to keep all properties in mind. An easier solution would be to wrap cpr::Session inside for example a std::shared_ptr.
COM8
force-pushed
the
fix/disable_session_move
branch
from
2b56200
to
47e7fa3
Compare
epicbigcat
added a commit
to AllayMC/AllayLauncher
that referenced
this pull request
Nov 18, 2024
note: after 1.11.0, `cpr::Session` is no longer movable & copyable: libcpr/cpr#999
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
cpr::Sessionis a complex object and while making it movable/copyable one has to keep all properties in mind. An easier solution would be to wrapcpr::Sessioninside for example astd::shared_ptrto allow it to be movable.Copyable does not make sense since a curl session is not copyable in a useful way.
What should happen if you copy a
cpr::Sessionin mids of a request? Should there be a new request with the same destination and the same connection state? This is not possible in a sensible way.Fixes #990.