Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential SSL Windows no revoke fix #889

Merged
merged 1 commit into from
Mar 26, 2023
Merged

Potential SSL Windows no revoke fix #889

merged 1 commit into from
Mar 26, 2023

Conversation

COM8
Copy link
Member

@COM8 COM8 commented Mar 17, 2023

Fixes #861

@COM8 COM8 merged commit 742fb6f into master Mar 26, 2023
@COM8 COM8 deleted the windows_no_revoke_fix branch March 26, 2023 07:28
COM8 added a commit that referenced this pull request Mar 26, 2023
Potential SSL Windows no revoke fix
COM8 added a commit that referenced this pull request Mar 26, 2023
Potential SSL Windows no revoke fix
@huytc
Copy link

huytc commented Apr 11, 2024

Hello @COM8 , I don't think this fixes the issue.

These changes made in this commit

#if SUPPORT_SSL_NO_REVOKE
    // NOLINTNEXTLINE (google-runtime-int)
    long bitmask{0};
    curl_easy_setopt(curl_->handle, CURLOPT_SSL_OPTIONS, &bitmask);
    const bool noRevoke = bitmask & CURLSSLOPT_NO_REVOKE;
#endif

does not store the currently applied CURLOPT_SSL_OPTIONS into bitmask, but instead set CURLOPT_SSL_OPTIONS to the address of the bitmask variable.

Sadly, from my understanding, libcurl's easy interface doesn't seem to provide a curl_easy_setopt method, so the only viable approach here is to store the SslOptions provided in SetSslOptions into a class variable, build a bitmask for the request, and finally call curl_easy_setopt(curl_->handle, CURLOPT_SSL_OPTIONS, bitmask) only once at the end.

@Nuxar1 Nuxar1 mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssl::NoRevoke{true} option is ignored
2 participants