Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed uninitialized C-arrays #1006

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Fixed uninitialized C-arrays #1006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eec4b44
Fixed uninitialized c-arrays
COM8 Jan 3, 2024
36409bc
Reduced the number of requests inside AsyncGetMultipleReflectTest
COM8 Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 22 additions & 21 deletions test/httpServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#include "httpServer.hpp"
#include <array>
#include <chrono>
#include <string>
#include <system_error>
Expand Down Expand Up @@ -394,12 +395,12 @@ void HttpServer::OnRequestUrlPost(mg_connection* conn, mg_http_message* msg) {

std::string headers = "Content-Type: application/json\r\n";

char x[100];
char y[100];
mg_http_get_var(&(msg->body), "x", x, sizeof(x));
mg_http_get_var(&(msg->body), "y", y, sizeof(y));
std::string x_string{x};
std::string y_string{y};
std::array<char, 100> x{0};
std::array<char, 100> y{0};
mg_http_get_var(&(msg->body), "x", x.data(), x.size());
mg_http_get_var(&(msg->body), "y", y.data(), y.size());
std::string x_string{x.data()};
std::string y_string{y.data()};
std::string response;
if (y_string.empty()) {
response = std::string{
Expand All @@ -418,7 +419,7 @@ void HttpServer::OnRequestUrlPost(mg_connection* conn, mg_http_message* msg) {
y_string +
",\n"
" \"sum\": " +
std::to_string(atoi(x) + atoi(y)) +
std::to_string(atoi(x.data()) + atoi(y.data())) +
"\n"
"}"};
}
Expand Down Expand Up @@ -519,12 +520,12 @@ void HttpServer::OnRequestDeleteNotAllowed(mg_connection* conn, mg_http_message*

void HttpServer::OnRequestPut(mg_connection* conn, mg_http_message* msg) {
if (std::string{msg->method.ptr, msg->method.len} == std::string{"PUT"}) {
char x[100];
char y[100];
mg_http_get_var(&(msg->body), "x", x, sizeof(x));
mg_http_get_var(&(msg->body), "y", y, sizeof(y));
std::string x_string = std::string{x};
std::string y_string = std::string{y};
std::array<char, 100> x{0};
std::array<char, 100> y{0};
mg_http_get_var(&(msg->body), "x", x.data(), x.size());
mg_http_get_var(&(msg->body), "y", y.data(), y.size());
std::string x_string{x.data()};
std::string y_string{y.data()};
std::string headers = "Content-Type: application/json\r\n";
std::string response;
if (y_string.empty()) {
Expand All @@ -544,7 +545,7 @@ void HttpServer::OnRequestPut(mg_connection* conn, mg_http_message* msg) {
y_string +
",\n"
" \"sum\": " +
std::to_string(atoi(x) + atoi(y)) +
std::to_string(atoi(x.data()) + atoi(y.data())) +
"\n"
"}"};
}
Expand Down Expand Up @@ -591,12 +592,12 @@ void HttpServer::OnRequestPutNotAllowed(mg_connection* conn, mg_http_message* ms

void HttpServer::OnRequestPatch(mg_connection* conn, mg_http_message* msg) {
if (std::string{msg->method.ptr, msg->method.len} == std::string{"PATCH"}) {
char x[100];
char y[100];
mg_http_get_var(&(msg->body), "x", x, sizeof(x));
mg_http_get_var(&(msg->body), "y", y, sizeof(y));
std::string x_string = std::string{x};
std::string y_string = std::string{y};
std::array<char, 100> x{0};
std::array<char, 100> y{0};
mg_http_get_var(&(msg->body), "x", x.data(), x.size());
mg_http_get_var(&(msg->body), "y", y.data(), y.size());
std::string x_string{x.data()};
std::string y_string{y.data()};
std::string headers = "Content-Type: application/json\r\n";
std::string response;
if (y_string.empty()) {
Expand All @@ -616,7 +617,7 @@ void HttpServer::OnRequestPatch(mg_connection* conn, mg_http_message* msg) {
y_string +
",\n"
" \"sum\": " +
std::to_string(atoi(x) + atoi(y)) +
std::to_string(atoi(x.data()) + atoi(y.data())) +
"\n"
"}"};
}
Expand Down
2 changes: 1 addition & 1 deletion test/session_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,7 +1361,7 @@ TEST(AsyncRequestsTests, AsyncGetMultipleTemporarySessionTest) {
TEST(AsyncRequestsTests, AsyncGetMultipleReflectTest) {
Url url{server->GetBaseUrl() + "/hello.html"};
std::vector<AsyncResponse> responses;
for (size_t i = 0; i < 100; ++i) {
for (size_t i = 0; i < 10; ++i) {
std::shared_ptr<Session> session = std::make_shared<Session>();
session->SetUrl(url);
session->SetParameters({{"key", std::to_string(i)}});
Expand Down
Loading