Comments, style.

libbitcoin · Aug 21, 2024 · 590919d · 590919d
1 parent 059d9f2
commit 590919d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/chain/script.cpp b/src/chain/script.cpp
@@ -270,8 +270,6 @@ void script::assign_data(reader& source, bool prefix) NOEXCEPT
     }
 
     valid_ = source;
-
-    // TODO: possible leak with linear arena allocation.
     offset = ops_.begin();
 }
 

diff --git a/src/chain/witness.cpp b/src/chain/witness.cpp
@@ -177,8 +177,8 @@ void witness::assign_data(reader& source, bool prefix) NOEXCEPT
         for (size_t element = 0; element < count; ++element)
         {
             const auto size = source.read_size(max_block_weight);
-            stack_.emplace_back(POINTER(data_chunk, allocator,
-                source.read_bytes_raw(size)));
+            const auto bytes = source.read_bytes_raw(size);
+            stack_.emplace_back(POINTER(data_chunk, allocator, bytes));
             size_ = element_size(size_, stack_.back());
         }
     }
@@ -187,8 +187,8 @@ void witness::assign_data(reader& source, bool prefix) NOEXCEPT
         while (!source.is_exhausted())
         {
             const auto size = source.read_size(max_block_weight);
-            stack_.emplace_back(POINTER(data_chunk, allocator,
-                source.read_bytes_raw(size)));
+            const auto bytes = source.read_bytes_raw(size);
+            stack_.emplace_back(POINTER(data_chunk, allocator, bytes));
             size_ = element_size(size_, stack_.back());
         }
     }