Fix building reproducible #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix reproducibility which currently may vary in between builds in the order the files are discovered in the file system.
SiegeLord
reviewed
Mar 4, 2024
docs/scripts/scan_examples.c
Outdated
| @@ -81,9 +90,13 @@ int main(int argc, char* argv[]) | |||
| lookup = calloc(argc, sizeof(lookup_t)); | |||
| for (j = 0; j < argc; ++j) { | |||
| lookup[j].index = j; | |||
| int len = strlen(argv[j]); | |||
There was a problem hiding this comment.
lookup[j].filename = strdup(argv[j]); ?
There was a problem hiding this comment.
Can't you just store the argv[i] pointer, no need to make a copy of the string it points to?
There was a problem hiding this comment.
@SiegeLord That seems very reasonable yes - and I have tested your method too now @pedro-w - that seems even better. I'll push to my branch here using this instead. Thanks!
SiegeLord
reviewed
Mar 4, 2024
|
Thanks, this is great work. I suggested some possible simplifications (the |
SiegeLord
reviewed
Mar 5, 2024
docs/scripts/scan_examples.c
Outdated
| } lookup_t; | ||
| static lookup_t *lookup; | ||
| static int number_of_items = 0; |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allegro-doc package doesn't build reproducible - these commits fix the "Last updated:" message on each html page by using the SOURCE_DATE_EPOCH build timestamp (more info here: https://reproducible-builds.org/docs/source-date-epoch/ ) and the other commit fix sorting example documents which are referenced alongside functions.
Original bug report in Debian here: https://bugs.debian.org/1064648 with links to more information regarding the problem.
https://reproducible-builds.org