fix: add code validation to workflows #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
tjvkroll
previously approved these changes
Sep 12, 2024
Wolftousen
approved these changes
Sep 16, 2024
Wolftousen
pushed a commit
that referenced
this pull request
Sep 16, 2024
## [1.0.3](v1.0.2...v1.0.3) (2024-09-16) ### Bug Fixes * add code validation to workflows ([#18](#18)) ([252edba](252edba))
|
🎉 This PR is included in version 1.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant changes to the CI/CD workflows and the
package.jsonconfiguration, along with some documentation updates. The most important changes include adding a new code validation workflow, updating dependencies and configurations inpackage.json, and modifying the README to reflect new installation instructions and image URLs so they will render on npm.CI/CD Workflow Improvements:
code_validation.ymlworkflow to handle linting, formatting, type checking, and unit tests. This workflow is now a prerequisite for the build and release jobs. (.github/workflows/build.yml,.github/workflows/release.yml) [1] [2]actions/checkoutto version 4 andactions/setup-nodeto version 4, and updated the build job to use.nvmrcfor the Node.js version and cache Yarn dependencies. (.github/workflows/build.yml)code_validation.ymljob.Package Configuration Updates:
package.jsonto include a description, keywords, repository information, and new scripts for Prettier and TypeScript checks. Also, changed the package name to@liatrio/backstage-dora-plugin. (package.json) [1] [2] [3] [4]Documentation Updates:
README.md) [1] [2] [3] [4] [5] [6]Miscellaneous:
.nvmrcfile specifying Node.js version 18.20.4. (.nvmrc)CHANGELOG.mdto.prettierignore. (.prettierignore)