Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently when my app has
enableShutdownHooks
it will fail every time because of:Digging through the NestJS source code and logging all the issues, this:
https://github.com/nestjs/nest/blob/master/packages/core/injector/module.ts#L611-L615
the
self.id
NEVER matches up with the ID of whateverthis.moduleRef.get<RedisModuleOptions>(REDIS_MERGED_OPTIONS)
or
this.moduleRef.get<RedisClients>(REDIS_CLIENTS)
is.This check always fails:
https://github.com/nestjs/nest/blob/master/packages/core/injector/instance-links-host.ts#L44-L46
This PR also address and fixes this issue:
#335
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information