Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getting the up-time more portable across unix-like systems #326

Merged
merged 3 commits into from
Dec 17, 2021
Merged

Make getting the up-time more portable across unix-like systems #326

merged 3 commits into from
Dec 17, 2021

Conversation

qiu-x
Copy link
Contributor

@qiu-x qiu-x commented Nov 6, 2021

This fixes #324

@qiu-x
Copy link
Contributor Author

qiu-x commented Nov 14, 2021

@liamg

@qiu-x
Copy link
Contributor Author

qiu-x commented Nov 14, 2021

From https://pkg.go.dev/cmd/go#hdr-Build_constraints:

Go versions 1.16 and earlier used a different syntax for build constraints, with a "// +build" prefix. The gofmt command will add an equivalent //go:build constraint when encountering the older syntax.

I suggest updating the Go version used in the checks. For now I will change my fix to use the old syntax.

Edit: Never mind, that would be a pretty bad solution since the new Go version does not support the old syntax, so the build would fail on new versions. So the best way to fix the errors in the checks is updating Go

@liamg liamg merged commit 97b6a41 into liamg:main Dec 17, 2021
@qiu-x qiu-x deleted the fbsd branch December 17, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails: undefined: syscall.Sysinfo_t
2 participants