Matter.Bodies.fromVertices fix: no longer returns 'undefined' #1137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to create Body with the method Matter.Bodies.fromVertices.
I installed poly-decomp package to enable automatic concave vertices decomposition and supply the the method Matter.Bodies.fromVertices with vertices from drawing.
However, for certain sets of vertices, the method Matter.Bodies.fromVertices would return
undefined
at line 354 of./src/factory/Bodies.js
This is due to
quickDecomp()
returns empty list of decomposition near line 278 of./src/factory/Bodies.js
./src/factory/Bodies.js
My change checks if the
parts
array is empty. If the array is empty, fallback to convex hull and ignore the decomposition.The final result would look like the following.