-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1 fixes #3
base: main
Are you sure you want to change the base?
Conversation
I changed the SWD header to match what it is on the Nucleo (swapped GND to pin 3) so we should have it match on all boards Add more mounting holes I got rid of the sw enabled pullups in favor of just headers Consider adding a PTC fuse in series with the jumper on CarCAN incase there's some fucky things that happen (our assumptions about bridging was wrong or user error). Are individual GPIO pins supplying the current to power segments on the display? The stm datasheet says all pins can only sink a total of 125 mA and each segment is 20 mA each (correct me if I'm wrong given the 2 datasheets). |
The overcurrent limit i set was based on the old requirement of current going through the connector since we're not doing that, do we want to set the current limit to be lower? (probably should've changed that on psom lmao) |
could we use smth like this to drive the seven segment? so GPIO pins don't have to supply current to the segments |
I made the current limit for the 12V line hella high, but that was before we changed the SOMs to not power the board. I'd change it to be like 500 mA. You should change the overcurrent condition to circuit breaker instead of current limiting like it is on psom. |
Typical forward voltage is 1.9 V at 2mA, which is exactly 5k, i'd make that 12V resistor a bit bigger. The resistor values you have on pp are from before I learned algebra so i'd update those. |
The TCAN chip fault pin is open drain so you should pull it up. Add decoupling caps to the CAN chip. I think the S pin has an integrated pulldown but you may want to add a pulldown on the CAN chip just in case. |
we thought about it but its kinda a big chip and we would need two. plus one 7seg draws 20mA max so the mcu should be able to sink it. if we do have problems though we can add that or maybe try and find a dual package one |
Quality Assurance Checklist
To make reviews more efficient, please make sure the board meets the following standards and check everything off once the board meets the quality check. Once everything has been checked, the assigned reviewers will begin the review process. Edit this description to check off the list.
There are exceptions with all guidelines. As long as your decisions are justified, then you are good! Contact the reviewers or the leads about any exceptions.
Please read every word on every bullet point before checking off the corresponding box.
Minimum Prerequisites
Please read every word on every bullet point before checking off the corresponding box.
Schematic Level Requirements
Please read every word on every bullet point before checking off the corresponding box.
BOM Requirements
Please read every word on every bullet point before checking off the corresponding box.
Layout Level Requirements
2D Spacing
3D Spacing
Components
Copper Layer
*Not really a problem for modern manufacturing techniques but good practice and important for high speed signal integrity.
Silkscreen Layer
Edge Cut Layer
Please read every word on every bullet point before checking off the corresponding box.
IMPORTANT NOTICE
Other Comments
pls review schematic