Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrl-f #363

Merged
merged 1 commit into from
Oct 14, 2023
Merged

ctrl-f #363

merged 1 commit into from
Oct 14, 2023

Conversation

Cam0Cow
Copy link
Contributor

@Cam0Cow Cam0Cow commented Oct 6, 2023

Quality Assurance Checklist

To make reviews more efficient, please make sure the software feature meets the following standards and check everything off that meets the quality check. Once everything has been checked, the assigned reviewers will begin the review process. Edit this description to check off the list.

There are exceptions with all guidelines. As long as your decisions are justified, then you are good! Contact the reviewers or the leads about any exceptions.

Requirements

  • Followed Coding Style Guide
  • Presented/discussed in some capacity with others on the Controls team
  • Code Build checks pass
  • No merge conflicts
  • Software feature has documentation for it updated in both ReadTheDocs and the comments
  • Software feature has documentation for it updated
  • Testing
    • Software feature has test associated with it
    • Test provides useful information and uses relevant data to accurately represent Controls
    • Tested on hardware
    • NOTE: If test file already exists, use that one
  • If applicable, have you added the new feature to main.c?
  • Tagged appropriate issue ticket on this PR
  • Did you have fun?

Things to Consider

  • Even if the above are checked, is this the best way of writing my code?
    • It's possible to write code that works, but are there ways to make code more efficient?

@Cam0Cow Cam0Cow requested a review from babusid October 6, 2023 22:26
@Cam0Cow
Copy link
Contributor Author

Cam0Cow commented Oct 6, 2023

Closes #362

@IshDeshpa IshDeshpa requested a review from manthanand October 14, 2023 18:15
@IshDeshpa IshDeshpa merged commit c7af939 into master Oct 14, 2023
2 checks passed
@Cam0Cow Cam0Cow deleted the sid_spelling branch October 31, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants