Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renode toolset #339

Merged
merged 31 commits into from
Nov 11, 2023
Merged

Renode toolset #339

merged 31 commits into from
Nov 11, 2023

Conversation

IshDeshpa
Copy link
Contributor

Grabbed some of the stuff from renode-test-framework and put it into this branch. Currently includes helpful scripts and VSCode integrations for testing with renode. Also renamed many files which is why this touches so many things.

@IshDeshpa IshDeshpa requested a review from Cam0Cow July 10, 2023 19:54
Cam0Cow
Cam0Cow requested changes Jul 10, 2023
View reviewed changes
Scripts/run_test.sh Outdated Show resolved Hide resolved
Tests/Leader/Test_Template.c Outdated Show resolved Hide resolved
Scripts/load_env_vars.sh Outdated Show resolved Hide resolved
@IshDeshpa
Copy link
Contributor Author

Instructions on how to test:

  • Open the LHR code workspace in .vscode from VSCode
  • Try running some of the tasks by pressing Ctrl-Shift-P and hitting Tasks: Run Task
  • Try debugging via the Run and Debug option on the left sidebar. This should attach directly to gdb through the Debug Console on the bottom panel, as well as open up Renode so that you can start the simulation. You can add breakpoints in the code (see Test_HelloWorld) directly through VSCode.

@IshDeshpa IshDeshpa marked this pull request as draft July 21, 2023 21:36
@Cam0Cow Cam0Cow marked this pull request as ready for review October 7, 2023 20:52
Cam0Cow
Cam0Cow previously approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@Cam0Cow Cam0Cow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for debugging on Renode

NathanielDelgado
NathanielDelgado previously approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@NathanielDelgado NathanielDelgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check the .cs files
Looks okay

.gitignore Show resolved Hide resolved
BSP/STM32F413/Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
Renode/STM32DMA_Fix.cs Outdated Show resolved Hide resolved
@IshDeshpa IshDeshpa dismissed stale reviews from NathanielDelgado and Cam0Cow via 402615c November 3, 2023 22:51
KnockbackNemo
KnockbackNemo previously approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@KnockbackNemo KnockbackNemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look through the files, but when I used it for testing, everything worked great for me!

Cam0Cow
Cam0Cow previously approved these changes Nov 11, 2023
View reviewed changes
NathanielDelgado
NathanielDelgado requested changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@NathanielDelgado NathanielDelgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments

.gitignore Outdated
@@ -4,3 +4,7 @@ __pycache__
*.csv
.vscode
*.swp
Tests/Results
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TAKE THIS OUT!!!

.vscode/LHR.code-workspace
"extensions": {
"recommendations": [
"ms-vscode.cpptools-extension-pack", // For Controls C code
"GitHub.vscode-pull-request-github", // For reviewing pull requests directly from VSCode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TAKE THIS OUT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Apps/Inc/Tasks.h Show resolved Hide resolved
BSP/STM32F413/Makefile Outdated
ifeq ($(DEBUG), 0)
OPT = -O3
else
OPT = -Og
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ADD -G

BSP/STM32F413/Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Renode/startup.resc Show resolved Hide resolved
Tests/Test_BSP_CAN.c Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DELETE!????

???

Tests/Test_HelloWorld.c Outdated Show resolved Hide resolved
Cam0Cow
Cam0Cow requested changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@Cam0Cow Cam0Cow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this

NathanielDelgado
NathanielDelgado approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@NathanielDelgado NathanielDelgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for tihs

Apps/Inc/Tasks.h Show resolved Hide resolved
Simulator/bpsSim.elf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♘💜 тคкＥ тℍＩ𝐒 ㄖＵｔ!!!

!!! 🍔🐍

Tests/Test_HelloWorld.c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Cam0Cow
Cam0Cow approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@Cam0Cow Cam0Cow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

85q03f

@IshDeshpa IshDeshpa merged commit 5f26308 into master Nov 11, 2023
2 checks passed
@Cam0Cow Cam0Cow deleted the renode-toolset branch November 25, 2023 17:50
@IshDeshpa IshDeshpa mentioned this pull request Jan 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanielDelgado NathanielDelgado NathanielDelgado approved these changes

@Cam0Cow Cam0Cow Cam0Cow approved these changes

@KnockbackNemo KnockbackNemo Awaiting requested review from KnockbackNemo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IshDeshpa @Cam0Cow @KnockbackNemo @NathanielDelgado