Update faultstate #312
Merged
Update faultstate #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More flexible CAN Send structure
…n signatures - Compile fixes for driver - Deprecated data types removed
- Minor bug fixes - Notice of deprecation for legacy MC driver
- Moved LUT struct def into the C file - fixed doc comments
- still need to make readfunc populate the idx field
- fixed comments - fixed lookup table type
… changed a bit of throwTaskError logic, removed some comments.
manthanand
reviewed
Oct 16, 2023
|
I think overall its kinda weird that the function throwTaskError is not called in task functions but in application level functions. I think it would make more sense if the app functions returned an error status that was used by the throwTaskError function in the actual task. This would probably make the architecture of the code a bit easier to understand in terms of data flow. |
…gs haven't changed since we weren't ever checking them anyways.
Accepted deletion of unnecessary tab Co-authored-by: Ishan Deshpande <[email protected]>
Cam0Cow
reviewed
Oct 21, 2023
NathanielDelgado
requested changes
Oct 21, 2023
There was a problem hiding this comment.
Make sure this works
…, changed the recoverability option to nonrecoverable.
…o update_faultstate
IshDeshpa
requested review from
Cam0Cow,
diyarajon and
NathanielDelgado
and removed request for
Cam0Cow
Cam0Cow
approved these changes
Oct 28, 2023
diyarajon
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.