Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the os_error_loc_t enum #333

Closed
KnockbackNemo opened this issue Jul 6, 2023 · 2 comments · Fixed by #366
Closed

Get rid of the os_error_loc_t enum #333

KnockbackNemo opened this issue Jul 6, 2023 · 2 comments · Fixed by #366
Assignees
Labels
enhancement New feature or request

Comments

@KnockbackNemo
Copy link
Contributor

All the assertOSError functions require a location, but we don't actually do anything with it. The only place the enum is actually useful is in assertTaskError and Display_Error. However, in assertTaskError it was intended to be replaced by a more proper system/enum later, and in Display_Error it will likely be deleted once we complete the issue ticket requesting changes to the display screen message.

@KnockbackNemo KnockbackNemo added the enhancement New feature or request label Jul 6, 2023
@IshDeshpa
Copy link
Contributor

Additionally, when implementing Display_Error, we can grab the last task from the previous tasks queue and send the display the name of the task where the fault happened. This would require additional work on the display end to support being sent a string and displaying it on the fault screen.

@Cam0Cow
Copy link
Contributor

Cam0Cow commented Oct 7, 2023

Additionally, when implementing Display_Error, we can grab the last task from the previous tasks queue and send the display the name of the task where the fault happened. This would require additional work on the display end to support being sent a string and displaying it on the fault screen.

Disregard this, the driver does not care which task the fault came from.

@zgonzalez24 zgonzalez24 linked a pull request Oct 21, 2023 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants