Buffer print #589
Merged
Buffer print #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiandahuang
requested changes
Sep 30, 2023
connorl309
reviewed
Nov 4, 2023
ray4477
reviewed
Nov 11, 2023
Tasks/Src/Task_Init.c
Outdated
| @@ -86,6 +87,14 @@ void Task_Init(void *p_arg) { | |||
| TASK_CLI_STACK_SIZE, // Stack size | |||
| ); | |||
| */ | |||
| RTOS_BPS_TaskCreate(&Print_TCB, | |||
There was a problem hiding this comment.
maybe a suggestion but theoretically we should only be doing buffer print when actively debugging, so maybe we can only define this task when some debug flag is set. This is optional though and doesn't matter too much if it adds complexity as the task is just above idle task in priority so its prob aight
Code-Tomato
previously approved these changes
Dec 2, 2023
Tasks/Src/Task_Print.c
Outdated
| Print_Queue_Pend(message, &len); | ||
|
|
||
| //Port 2 for now | ||
| BSP_UART_Write(message, len, UART_USB); |
There was a problem hiding this comment.
We should check the speed of this in the future. If it is too slow, we should make it interrupt-based
Print queue completed in theory builds now hehe Test Saturday Changes :) fix sim issue build fix some changes updated mutex buffer inshallah it wokrs work in progress work in progress Changed printFifo. Needs >256 char string testing the message lenght was wrong... pushin few logic fixes comments making tests fixed retarget tests build reverted append fixed retarget again changed copyright for 2023 applied changes from suggestions /r one bug fix fixed smile? now it compiles!! *surprised pikachu face got rid of fifo changes - want a separate PR comment fix build here you go nathan nathan big brain fix RENAMED STUFF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quality Assurance Checklist
To make reviews more efficient, please make sure the software feature meets the following standards and check everything off that meets the quality check. Once everything has been checked, the assigned reviewers will begin the review process. Edit this description to check off the list.
There are exceptions with all guidelines. As long as your decisions are justified, then you are good! Contact the reviewers or the leads about any exceptions.
Requirements
Things to Consider