Skip to content

Commit

Permalink
[RAM] Text not localized on rules managament table (elastic#166700)
Browse files Browse the repository at this point in the history
## Summary

Fixed issue: elastic#165552 for all
existing locale.

Looked before:
<img width="1049" alt="Screenshot 2023-09-19 at 12 24 08"
src="https://github.com/elastic/kibana/assets/26089545/540af16a-d5e9-4965-b13b-0e28733ed947">


Now looks like this:
<img width="1225" alt="Screenshot 2023-09-19 at 12 19 49"
src="https://github.com/elastic/kibana/assets/26089545/58fdffdb-8516-4690-b026-d59ce02a0374">

---------

Co-authored-by: Kibana Machine <[email protected]>
  • Loading branch information
guskovaue and kibanamachine authored Sep 27, 2023
1 parent de0e1eb commit 255bf6e
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 10 deletions.
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/fr-FR.json
Original file line number Diff line number Diff line change
Expand Up @@ -38510,7 +38510,6 @@
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.editButtonTooltip": "Modifier",
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.intervalIconAriaLabel": "Au-dessous de l'intervalle minimal configuré",
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.intervalTooltipTitle": "Au-dessous de l'intervalle minimal configuré",
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.lastExecutionDateTitle": "Heure de début de la dernière exécution.",
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.lastResponseTitle": "Dernière réponse",
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.nameTitle": "Nom",
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.notifyTitle": "Notifier",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -38501,7 +38501,6 @@
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.editButtonTooltip": "編集",
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.intervalIconAriaLabel": "構成された最小間隔未満",
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.intervalTooltipTitle": "構成された最小間隔未満",
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.lastExecutionDateTitle": "前回の実行の開始時間。",
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.lastResponseTitle": "前回の応答",
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.nameTitle": "名前",
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.notifyTitle": "通知",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -38495,7 +38495,6 @@
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.editButtonTooltip": "编辑",
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.intervalIconAriaLabel": "低于配置的最小时间间隔",
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.intervalTooltipTitle": "低于配置的最小时间间隔",
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.lastExecutionDateTitle": "上次运行的开始时间。",
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.lastResponseTitle": "上次响应",
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.nameTitle": "名称",
"xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.notifyTitle": "通知",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const getLastUpdateText = (lastUpdate: string) => {
{
defaultMessage: 'Updated {lastUpdateText}',
values: {
lastUpdateText: moment(lastUpdate).fromNow(),
lastUpdateText: moment(lastUpdate).locale(i18n.getLocale()).fromNow(),
},
}
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -413,14 +413,17 @@ export const RulesListTable = (props: RulesListTableProps) => {
<EuiToolTip
data-test-subj="rulesTableCell-lastExecutionDateTooltip"
content={i18n.translate(
'xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.lastExecutionDateTitle',
'xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.lastRunTitleTooltip',
{
defaultMessage: 'Start time of the last run.',
}
)}
>
<span>
Last run{' '}
{i18n.translate(
'xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.lastRunTitle',
{ defaultMessage: 'Last run' }
)}
<EuiIcon size="s" color="subdued" type="questionInCircle" className="eui-alignTop" />
</span>
</EuiToolTip>
Expand Down Expand Up @@ -569,14 +572,17 @@ export const RulesListTable = (props: RulesListTableProps) => {
<EuiToolTip
data-test-subj="rulesTableCell-durationTooltip"
content={i18n.translate(
'xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.durationTitle',
'xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.durationTitleTooltip',
{
defaultMessage: 'The length of time it took for the rule to run (mm:ss).',
}
)}
>
<span>
Duration{' '}
{i18n.translate(
'xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.durationTitle',
{ defaultMessage: 'Duration' }
)}
<EuiIcon size="s" color="subdued" type="questionInCircle" className="eui-alignTop" />
</span>
</EuiToolTip>
Expand Down Expand Up @@ -639,14 +645,17 @@ export const RulesListTable = (props: RulesListTableProps) => {
<EuiToolTip
data-test-subj="rulesTableCell-successRatioTooltip"
content={i18n.translate(
'xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.successRatioTitle',
'xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.successRatioTitleTooltip',
{
defaultMessage: 'How often this rule runs successfully.',
}
)}
>
<span>
Success ratio{' '}
{i18n.translate(
'xpack.triggersActionsUI.sections.rulesList.rulesListTable.columns.successRatioTitle',
{ defaultMessage: 'Success ratio' }
)}
<EuiIcon size="s" color="subdued" type="questionInCircle" className="eui-alignTop" />
</span>
</EuiToolTip>
Expand Down

0 comments on commit 255bf6e

Please sign in to comment.