Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speed up package load time #201

Closed
jorainer opened this issue Apr 5, 2017 · 5 comments
Closed

speed up package load time #201

jorainer opened this issue Apr 5, 2017 · 5 comments

Comments

@jorainer
Copy link
Collaborator

jorainer commented Apr 5, 2017

The loading time for MSnbase is quite long. I was wondering if we could reduce the package loading time (about 3.3 secs on my computer). This would be specifically helpful for parallel processing using SnowParam (only parallel processing available in Windows).

I guess the loading time is a combination of time spent on the imports and on the exports - so I guess there is not much that can be done.
@lgatto
Copy link
Owner

lgatto commented Apr 6, 2017

It would be great if we could to that. Maybe worth exploring:

  • move some packages from depends to imports in the description
  • reduce import to importFrom in the namespace

@jorainer
Copy link
Collaborator Author

jorainer commented Apr 6, 2017

I'll play a little around with that and what speed improvement we could get.

sgibb added a commit that referenced this issue Apr 6, 2017
@sgibb
remove reshape2; see #201
f1ec84d
@sgibb
Copy link
Collaborator

sgibb commented Apr 6, 2017

We could also review all Depends and Suggests. E.g. reshape2 is just used for melt (which could easily replaced), see #202 for example. (I am not sure whether @lgatto want to merge this now, or want to wait for the next release cycle).

@lgatto
Copy link
Owner

lgatto commented Apr 6, 2017

As long as changes are relatively minor, like #202, I am happy to merge now.

lgatto pushed a commit that referenced this issue Apr 6, 2017
@LaurentGatto
Merge pull request #202 from lgatto/reshape2
d67ab4d 
remove reshape2; see #201
@jorainer
Copy link
Collaborator Author

jorainer commented Apr 6, 2017

I would rather like to change stuff later - don't want to break things again ;)

lgatto pushed a commit that referenced this issue Apr 9, 2017
Merge branch 'master' into devel
08d92ea 
* master:
  remove reshape2; see #201

From: Laurent <[email protected]>

git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/MSnbase@128142 bc3139a8-67e5-0310-9ffc-ced21a209358
sgibb referenced this issue Jul 30, 2017
@LaurentGatto
add utils functions and new as(mzRident, "data.frame")
92d5724
lgatto pushed a commit that referenced this issue Sep 7, 2017
Merge branch 'master' into devel
a9750fd 
* master:
  remove reshape2; see #201

From: Laurent <[email protected]>

git-svn-id: file:///home/git/hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/MSnbase@128142 bc3139a8-67e5-0310-9ffc-ced21a209358
@sgibb sgibb mentioned this issue Mar 18, 2018
Merged
@sgibb sgibb mentioned this issue Oct 19, 2018
Merged
@lgatto lgatto mentioned this issue Mar 4, 2019
Closed
@lgatto lgatto closed this as completed Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lgatto @sgibb @jorainer